fix(coding-agent): synced v15.13 settings, help, status, and docs surfaces#2627
fix(coding-agent): synced v15.13 settings, help, status, and docs surfaces#2627roboomp wants to merge 2 commits into
Conversation
…faces
- Regrouped speech (`speech.*`, `tts.*`, `providers.tts`, `stt.language`, `speechgen.enabled`) under interaction/Speech and gated mode/voice on `speech.enabled` and local-TTS on `providers.tts ∈ {auto, local}`.
- Gated Mnemopi remote-LLM rows behind `mnemopi.llmMode == remote` and embedding rows behind `!mnemopi.noEmbeddings`; gated Exa child rows behind `exa.enabled`; gated SearxNG and compaction-remote rows behind their masters.
- Dropped the duplicate boolean `mcp.discoveryMode` UI in favor of the enum `tools.discoveryMode`.
- Surfaced previously config-only settings in `/settings`: `retry.enabled` (and gated children), `skills.enabled` (gating `skills.enableSkillCommands`), `stt.language`, `compaction.autoContinue`, `compaction.remoteEndpoint`, `shellPath`, `searxng.categories`/`language`, and Hindsight `recallBudget`/`bankMission`/`retainMission`/`retainContext`.
- Added a CONDITIONS registry covering every new gate and a regression test asserting every `ui.condition` resolves to a registered predicate.
- Added speech and auto-learn status-line indicators next to the model segment, documented `Ctrl+J` in hotkeys and `docs/keybindings.md`, and updated `/fast` and `/guided-goal` help to mention `fastModeScope` and the guided interview.
- Added `docs/tools/learn.md` and `docs/tools/manage-skill.md`, documented the task `role` parameter and the IRC work-aware `activity` field, and added `fastModeScope` / `task.eager` / `todo.eager` / `searxng.categories` / `searxng.language` to `docs/settings.md`.
Fixes #2621
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dceb4916a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| ### Added | ||
|
|
||
| - Added `WebSearchProviderError` class with HTTP status for actionable provider error messages |
There was a problem hiding this comment.
Restore released changelog entries
The repo AGENTS.md says already-released changelog sections are immutable, but this is one of the already-shipped bullets moved back under ## [Unreleased] while the same commit deletes it from a released section. That corrupts release history and makes the next release announce old work again; restore the released-section entries and leave only genuinely new changes under Unreleased.
Useful? React with 👍 / 👎.
Repro
Two checks against the current branch reproduce the drift the issue describes. A schema probe —
bun -e "import { SETTINGS_SCHEMA } …"— confirmsretry.enabled,skills.enabled,stt.language,compaction.autoContinue,compaction.remoteEndpoint,shellPath,searxng.categories,searxng.language, and the HindsightrecallBudget/bankMission/retainMission/retainContextkeys had nouimetadata; speech keys lived underproviders/Services; Exa children were ungated; andmcp.discoveryModestill had auiblock besidetools.discoveryMode. A docs probe showsCtrl+J,fastModeScope,task.eager,todo.eager, the taskroleparameter, anddocs/tools/learn.md/docs/tools/manage-skill.mdmissing.Cause
The v15.13.x features landed without updating the corresponding
uimetadata inpackages/coding-agent/src/config/settings-schema.ts, theCONDITIONSregistry inpackages/coding-agent/src/modes/components/settings-defs.ts, the status-line model segment inpackages/coding-agent/src/modes/components/status-line/segments.ts, the/fastand/guided-goalentries inpackages/coding-agent/src/slash-commands/builtin-registry.ts, the in-app hotkeys inpackages/coding-agent/src/modes/utils/hotkeys-markdown.ts, or the tool/keybinding/settings docs.Fix
speech.*,tts.*,providers.tts,stt.language, andspeechgen.enabledunderinteraction / Speech; gated speech mode/voice onspeech.enabledand the local-TTS rows onproviders.tts ∈ {auto, local}. Gated Mnemopi remote-LLM rows behindmnemopi.llmMode == remoteand embedding rows behind!mnemopi.noEmbeddings. Gated Exa children behindexa.enabled. Dropped the duplicatemcp.discoveryModeUI in favor of the enumtools.discoveryMode. Addeduiblocks for the previously config-onlyretry.enabled,skills.enabled,stt.language,compaction.autoContinue,compaction.remoteEndpoint,shellPath,searxng.categories/language, and the Hindsight knobs; theretry.*andskills.enableSkillCommandschildren now gate on their masters.retryActive,skillsActive,compactionActive,remoteCompactionActive,exaActive,searxngActive,sttActive,speechActive,localTtsActive,mnemopiRemoteLlmActive,mnemopiEmbeddingsActive, and themnemopiActive/hindsightActive/autolearnActive/autoThinkingActivesiblings toCONDITIONS; covered by a new regression test that walks everyui.conditionagainst the registry.speechandlearnflags next to the model segment viaappendModelFlag/sessionSettingEnabled, mirroring the existing fast-mode icon.Ctrl+Jtohotkeys-markdown.tsanddocs/keybindings.md; updated/fastto mentionfastModeScopeand/guided-goalto mention the guided interview; updatedprompts/tools/irc.mdto call out the work-awareactivity; documented the taskroleparameter indocs/tools/task.mdand the IRCactivityfield indocs/tools/irc.md; added newdocs/tools/learn.mdanddocs/tools/manage-skill.md; addedfastModeScope,task.eager,todo.eager,searxng.categories, andsearxng.languagetodocs/settings.md.Verification
bun --cwd=packages/coding-agent test test/modes/components/settings-layout.test.ts test/fast-mode-scope.test.ts test/modes/controllers/command-controller-hotkeys.test.ts test/goals/guided-goal.test.ts test/status-line-transparent.test.ts test/status-line-overflow.test.ts test/status-line-context-cache.test.ts test/status-line-settings-cache.test.ts→ 47 pass / 0 fail.bun -eschema probe — every previously missing key now hasuimetadata, every speech key lives underinteraction/Speech, Exa children carryexaActive, Mnemopi children carrymnemopiRemoteLlmActive/mnemopiEmbeddingsActive, andmcp.discoveryModeno longer has auiblock.bun -edocs probe —Ctrl+J,fastModeScope,task.eager,todo.eager, taskrole, and the two new tool docs are all present.bun run check:tools,bun --cwd=packages/coding-agent run check, andbun --cwd=packages/coding-agent run check:typesall pass locally.Fixes #2621